refactor: Localize single-consumer types (issue #643 phase 3) - #806
Merged
Conversation
Move ActorInputSchemaProperties from src/types.ts to src/tools/utils.ts as a private type alias (its only consumer). Note: spec listed several other types (ActorChargeEvent, ActorPricingModel, TieredPricing, PricingInfo, PricePerEventActorPricingInfo) but they have already been localized to their respective modules. The actor_card.ts import update is also already in place. Only ActorInputSchemaProperties remained in src/types.ts.
MQ37
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3 of #643 — localize single-consumer types from
src/types.ts.Move applied
ActorInputSchemaPropertiessrc/tools/utils.ts(private)index*.tsStale spec items (already in place on master)
The following Phase 3 items were already done in earlier work — no change needed:
ActorChargeEvent— already insrc/utils/pricing_info.tsActorPricingModel— already private insrc/utils/actor_search.tsTieredPricing,PricingInfo,PricePerEventActorPricingInfo— already insrc/utils/pricing_info.ts(PricePerEventActorPricingInfois already private)src/utils/actor_card.tsalready importsPricingInfofrom./pricing_info.jsVerification
npm run type-checkpassesnpm run lintpassesnpm run test:unitpasses (613 passed, 4 skipped)Related: #643
Generated by Claude Code